Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model/profile: deal properly with dynamic metric names #2955

Closed
axw opened this issue Nov 22, 2019 · 1 comment
Closed

model/profile: deal properly with dynamic metric names #2955

axw opened this issue Nov 22, 2019 · 1 comment
Assignees

Comments

@axw
Copy link
Member

axw commented Nov 22, 2019

Currently we will record any pprof sample values, but we rename the unit "nanoseconds" to "ns". However, the index mapping is not dynamic, and we only define fields for a well-known set of metrics:

  • profile.cpu.ns
  • profile.samples.count
  • profile.alloc_objects.count
  • profile.alloc_space.bytes
  • profile.inuse_objects.count
  • profile.inuse_space.bytes

We should either limit to indexing these metrics, or we should move them under a sub-group and make that dynamic.

@axw
Copy link
Member Author

axw commented Jul 25, 2022

I'll resurrect the issue if/when we come back to this.

@axw axw closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants