Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregation/txmetrics: exclude user_agent.original from grouping #3841

Closed
axw opened this issue Jun 3, 2020 · 0 comments · Fixed by #3848
Closed

aggregation/txmetrics: exclude user_agent.original from grouping #3841

axw opened this issue Jun 3, 2020 · 0 comments · Fixed by #3848
Assignees
Milestone

Comments

@axw
Copy link
Member

axw commented Jun 3, 2020

We need the browser name included in grouping keys for RUM. In the initial implementation I just included user_agent.original, hoping we could get away with having few unique values per aggregation interval. However, even if we do that, we'll still have many metrics docs over a longer period, which will slow down UI queries.

In the short term we should remove user_agent.original from the grouping, which will cause the UI to continue to use transaction docs for the browser metrics. In the longer term, we should add user_agent.name, which requires parsing the User-Agent in apm-server.

See also #3814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant