Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ABC deprecation warning #5

Closed
n0mn0m opened this issue Apr 8, 2019 · 2 comments
Closed

Fix ABC deprecation warning #5

n0mn0m opened this issue Apr 8, 2019 · 2 comments

Comments

@n0mn0m
Copy link

n0mn0m commented Apr 8, 2019

Python 3.7 deprecated importing ABCs from collections instead we need to use collections.abc.

/Users/alexander/.pyenv/versions/3.7.2-debug/Python.framework/Versions/3.7/lib/python3.7/site-packages/botocore-1.12.129-py3.7.egg/botocore/vendored/requests/packages/urllib3/_collections.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Mapping, MutableMapping
@n0mn0m
Copy link
Author

n0mn0m commented Apr 8, 2019

Actually this is upstream in boto sorry should have read a bit further there. I'll setup a PR there if this isn't already fixed.

@n0mn0m n0mn0m closed this as completed Apr 8, 2019
@n0mn0m
Copy link
Author

n0mn0m commented Apr 8, 2019

boto/botocore#1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@n0mn0m