Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the Elasticsearch output and the Elasticsearch client #11068

Closed
ph opened this issue Mar 4, 2019 · 2 comments
Closed

Split the Elasticsearch output and the Elasticsearch client #11068

ph opened this issue Mar 4, 2019 · 2 comments
Assignees
Labels
enhancement libbeat Team:Integrations Label for the Integrations team

Comments

@ph
Copy link
Contributor

ph commented Mar 4, 2019

Linked to #10547 and #10491


We have found a few issues concerning output reloading triggered by a CM changes, the problem is we have a hard time to make the fix because the code of the Elasticsearch output is also used in other places in the code base for servers request, like uploading templates, uploading pipeline, checking for license.

We have decided to do the following steps:

  • Extract the API layer in a esclientleg AKA Legacy
  • Simplify the Elasticsearch output by only having the related code for publishing events and closing the output.
  • Give us a migration path to the official ES golang client.
@andresrc
Copy link
Contributor

@ycombinator what's missing to close this one?

@ycombinator
Copy link
Contributor

This is done now, via #16150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement libbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

3 participants