Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_cloud_metadata processor overwrites fields when field keys contains dots #11697

Closed
kaiyan-sheng opened this issue Apr 8, 2019 · 2 comments
Assignees
Labels
discuss Issue needs further discussion. Team:Integrations Label for the Integrations team

Comments

@kaiyan-sheng
Copy link
Contributor

In #11612, we realized when overwrite flag equals false in add_cloud_metadata processor, it checks if cloud field exists but can't deal with when field key containing dots for example cloud.provider. Please see TestRetrieveAWSMetadata in provider_aws_ec2_test.go for more details.

This PR is to discuss if add_cloud_metadata processor needs to deal with dots in field keys and if so what's the best implementation here.

@kaiyan-sheng
Copy link
Contributor Author

In #11612, I tried out some code to check if field key starts with cloud., if so, add_cloud_metadata should not overwrite cloud fields: https://github.com/elastic/beats/blob/38badaa57f14922562520ee38de7b9b5aba0aacf/libbeat/processors/add_cloud_metadata/add_cloud_metadata.go#L372

@jlind23
Copy link
Collaborator

jlind23 commented Apr 1, 2022

Backlog grooming: Closing it for now until further activity, can still be reopened if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

4 participants