Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hints based autodiscover based on namespace metadata #13913

Closed
exekias opened this issue Oct 4, 2019 · 7 comments
Closed

Allow hints based autodiscover based on namespace metadata #13913

exekias opened this issue Oct 4, 2019 · 7 comments
Labels
containers Related to containers use case discuss Issue needs further discussion. enhancement Team:Integrations Label for the Integrations team

Comments

@exekias
Copy link
Contributor

exekias commented Oct 4, 2019

Once we get namespace metadata in #13873, it should be possible to use it for hints based autodiscover.

Users should be able to set hints at the namespace level, so they don't need to repeat them across all pods in the namespace. Hints from the namespace and the Pod should be merged. If one is present in both the namespace and the pod, the one in the Pod overrides the namespace's.

For instance, adding this hint to a namespace should make Filebeat ignore logs from all its pods: co.elastic.logs/enabled: false. While if co.elastic.logs/enabled: true is added to a pod in the namespace, its logs should be retrieved.

@exekias exekias added enhancement discuss Issue needs further discussion. containers Related to containers use case Team:Integrations Label for the Integrations team labels Oct 4, 2019
@exekias
Copy link
Contributor Author

exekias commented Oct 4, 2019

cc @odacremolbap @ChrsMark @sorantis

@jsoriano
Copy link
Member

jsoriano commented Oct 8, 2019

This could be a fix for some use cases related to #9123

@botelastic
Copy link

botelastic bot commented Sep 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Sep 14, 2020
@sorantis
Copy link
Contributor

keep open

@botelastic botelastic bot removed the Stalled label Sep 14, 2020
@jsoriano
Copy link
Member

Would this be solved by #16321?

@ChrsMark
Copy link
Member

Would this be solved by #16321?

Looks like yes! @exekias could you confirm that?

@exekias
Copy link
Contributor Author

exekias commented Sep 17, 2020

++ closing

@exekias exekias closed this as completed Sep 17, 2020
@zube zube bot removed the [zube]: Done label Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case discuss Issue needs further discussion. enhancement Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

5 participants