Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Refactor: Export our log using libbeat logging library.; #15129

Closed
ph opened this issue Dec 16, 2019 · 9 comments · Fixed by #19211
Closed

[Agent] Refactor: Export our log using libbeat logging library.; #15129

ph opened this issue Dec 16, 2019 · 9 comments · Fixed by #19211
Assignees
Labels
Ingest Management:beta1 Group issues for ingest management beta1 [zube]: In Progress

Comments

@ph
Copy link
Contributor

ph commented Dec 16, 2019

We are using ecslog library in the wrong way, let's reduce the risk and move back to libbeat's logging library and have the same behavior as any other beats.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest (Project:fleet)

@ph
Copy link
Contributor Author

ph commented Dec 16, 2019

related to #15128

cc @michalpristas for awareness.

@ph ph self-assigned this Jan 14, 2020
@ph
Copy link
Contributor Author

ph commented Jan 14, 2020

Okay, we have to support logging into the ECS format for the first release, I think the main problem is we do not use the ECS log library as intended. I am going to take a look at that.

@ph ph changed the title [Agent] Refactor: move from ecslog to logp. [Agent] Refactor: Export our log in the ECS Log format Jan 14, 2020
@webmat
Copy link
Contributor

webmat commented Jan 14, 2020

Hey @ph, with the new ECS logging initiative, all of the logging libraries are being created in separate repos. The Go ECS library should be moved outside of the ECS repo as well, ideally.

Do you think it's something you could help with, in this process?

@ph
Copy link
Contributor Author

ph commented Jan 14, 2020

@webmat The problem is the POC that @urso created might not directly aligned with the goal of the ECS logging initiative, I will check what I can do to help.

@ph
Copy link
Contributor Author

ph commented Jan 14, 2020

removing myself until #15544 is resolved.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:ingest-management)

@ph ph self-assigned this May 25, 2020
@ph
Copy link
Contributor Author

ph commented May 25, 2020

I need to clarify the requirement here.

@ph ph added Ingest Management:beta1 Group issues for ingest management beta1 and removed ingest:beta1 labels May 25, 2020
@ph ph assigned michalpristas and unassigned ph and michalpristas Jun 8, 2020
@ph
Copy link
Contributor Author

ph commented Jun 12, 2020

@michalpristas I've updated the description to reflect the actual work.

@ph ph changed the title [Agent] Refactor: Export our log in the ECS Log format [Agent] Refactor: Export our log using libbeat logging library.; Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:beta1 Group issues for ingest management beta1 [zube]: In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants