Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aws_elb autodiscover provider meta field prefix to aws.elb #16219

Closed
kaiyan-sheng opened this issue Feb 10, 2020 · 3 comments · Fixed by #16402
Closed

Change aws_elb autodiscover provider meta field prefix to aws.elb #16219

kaiyan-sheng opened this issue Feb 10, 2020 · 3 comments · Fixed by #16402
Assignees
Labels

Comments

@kaiyan-sheng
Copy link
Contributor

This issue came from comment #14823 (comment) when adding aws_ec2 autodiscover provider in #14823. In aws_ec2 provider, meta fields are started with aws.ec2 to match metrics from aws module Metricbeat.

Similarly, it would be good to update aws_elb provider to also have aws.elb prefix for meta fields. Also meta fields are not added to autodiscover template, similar to #14823 (comment).

@kaiyan-sheng
Copy link
Contributor Author

@andrewvc aws_elb is experimental, does that mean we can make the change without waiting till 8.0.0?

@andrewvc
Copy link
Contributor

That's a good point @kaiyan-sheng , given the experimental status I'm OK with this. Do you mind updating the docs as well?

@kaiyan-sheng
Copy link
Contributor Author

@andrewvc Will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants