Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Add stackdriver metricset for googlecloud module #16785

Closed
11 tasks
kaiyan-sheng opened this issue Mar 4, 2020 · 2 comments · Fixed by #18398
Closed
11 tasks

[Metricbeat] Add stackdriver metricset for googlecloud module #16785

kaiyan-sheng opened this issue Mar 4, 2020 · 2 comments · Fixed by #18398
Assignees
Labels
Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team

Comments

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Mar 4, 2020

Similar to cloudwatch in aws module, we should create a stackdriver metricset for googlecloud module.

Modules

For a metricset to go GA, the following criterias should be met:

  • Supported versions are documented
  • Supported operating systems are documented (if applicable)
  • Integration tests exist
  • System tests exist
  • Automated checks that all fields are documented
  • Documentation
  • Fields follow ECS and naming conventions
  • Dashboards exists (if applicable)
  • Kibana Home Tutorial (if applicable)
    • Open PR against Kibana repo with tutorial. Examples can be found here.

Metricbeat module

  • Example data.json exists and an automated way to generate it exists (go test -data)
  • Test environment in Docker exist for integration tests
@kaiyan-sheng kaiyan-sheng added Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team labels Mar 4, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 4, 2020
@andresrc
Copy link
Contributor

andresrc commented May 8, 2020

@kaiyan-sheng can you link the relevant PRs and update the status? Thanks!

@kaiyan-sheng
Copy link
Contributor Author

Here is the PR for adding aligner parameter and documentation into stackdriver: #17719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants