Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] make check fails on CI #16840

Closed
kuisathaverat opened this issue Mar 5, 2020 · 3 comments
Closed

[CI] make check fails on CI #16840

kuisathaverat opened this issue Mar 5, 2020 · 3 comments
Assignees
@kuisathaverat
Labels
automation ci

Comments

@kuisathaverat
Copy link
Contributor

After enabled the Go modules the Lint stage start failing on the make check command with the following error:

[2020-03-05T13:50:43.371Z] go: extracting github.com/go-stack/stack v1.8.0
[2020-03-05T13:50:43.632Z] diff --git a/go.mod b/go.mod
[2020-03-05T13:50:43.632Z] index d49fb8a..fec03c8 100644
[2020-03-05T13:50:43.632Z] --- a/go.mod
[2020-03-05T13:50:43.632Z] +++ b/go.mod
[2020-03-05T13:50:43.632Z] @@ -140,19 +140,19 @@ require (
[2020-03-05T13:50:43.632Z]  	go.uber.org/zap v1.7.1
[2020-03-05T13:50:43.632Z]  	golang.org/x/crypto v0.0.0-20200204104054-c9f3fb736b72
[2020-03-05T13:50:43.632Z]  	golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f
[2020-03-05T13:50:43.632Z] -	golang.org/x/net v0.0.0-20200202094626-16171245cfb2
[2020-03-05T13:50:43.632Z] +	golang.org/x/net v0.0.0-20200226121028-0de0cce0169b
[2020-03-05T13:50:43.632Z]  	golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
[2020-03-05T13:50:43.632Z]  	golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
[2020-03-05T13:50:43.632Z] -	golang.org/x/sys v0.0.0-20200102141924-c96a22e43c9c
[2020-03-05T13:50:43.632Z] +	golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527
[2020-03-05T13:50:43.632Z]  	golang.org/x/text v0.3.2
[2020-03-05T13:50:43.632Z]  	golang.org/x/time v0.0.0-20191024005414-555d28b269f0
[2020-03-05T13:50:43.632Z] -	golang.org/x/tools v0.0.0-20191227053925-7b8e75db28f4
[2020-03-05T13:50:43.632Z] +	golang.org/x/tools v0.0.0-20200304193943-95d2e580d8eb
[2020-03-05T13:50:43.632Z]  	google.golang.org/api v0.15.0
[2020-03-05T13:50:43.632Z]  	google.golang.org/genproto v0.0.0-20191230161307-f3c370f40bfb
[2020-03-05T13:50:43.632Z]  	gopkg.in/inf.v0 v0.9.0
[2020-03-05T13:50:43.632Z]  	gopkg.in/jcmturner/gokrb5.v7 v7.3.0 // indirect
[2020-03-05T13:50:43.632Z]  	gopkg.in/mgo.v2 v2.0.0-20160818020120-3f83fa500528
[2020-03-05T13:50:43.632Z] -	gopkg.in/yaml.v2 v2.2.7
[2020-03-05T13:50:43.632Z] +	gopkg.in/yaml.v2 v2.2.8
[2020-03-05T13:50:43.632Z]  	howett.net/plist v0.0.0-20181124034731-591f970eefbb
[2020-03-05T13:50:43.632Z]  	k8s.io/api v0.0.0-20190722141453-b90922c02518
[2020-03-05T13:50:43.632Z]  	k8s.io/apimachinery v0.0.0-20190719140911-bfcf53abc9f8
[2020-03-05T13:50:43.632Z] diff --git a/go.sum b/go.sum
[2020-03-05T13:50:43.632Z] index d95286d..f95d8e9 100644
[2020-03-05T13:50:43.632Z] --- a/go.sum
[2020-03-05T13:50:43.632Z] +++ b/go.sum
[2020-03-05T13:50:43.632Z] @@ -674,6 +674,8 @@ golang.org/x/mobile v0.0.0-20190719004257-d2bd2a29d028/go.mod h1:E/iHnbuqvinMTCc
[2020-03-05T13:50:43.632Z]  golang.org/x/mod v0.0.0-20190513183733-4bf6d317e70e/go.mod h1:mXi4GBBbnImb6dmsKGUJ2LatrhH/nqhxcFungHvyanc=
[2020-03-05T13:50:43.632Z]  golang.org/x/mod v0.1.0/go.mod h1:0QHyrYULN0/3qlju5TqG8bIK38QM8yzMo5ekMj3DlcY=
[2020-03-05T13:50:43.632Z]  golang.org/x/mod v0.1.1-0.20191105210325-c90efee705ee/go.mod h1:QqPTAvyqsEbceGzBzNggFXnrqF1CaUcvgkdR5Ot7KZg=
[2020-03-05T13:50:43.632Z] +golang.org/x/mod v0.2.0 h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=
[2020-03-05T13:50:43.632Z] +golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
[2020-03-05T13:50:43.632Z]  golang.org/x/net v0.0.0-20170114055629-f2499483f923/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
[2020-03-05T13:50:43.632Z]  golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
[2020-03-05T13:50:43.632Z]  golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
[2020-03-05T13:50:43.632Z] @@ -698,6 +700,8 @@ golang.org/x/net v0.0.0-20191209160850-c0dbc17a3553/go.mod h1:z5CRVTTTmAJ677TzLL
[2020-03-05T13:50:43.632Z]  golang.org/x/net v0.0.0-20200114155413-6afb5195e5aa/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
[2020-03-05T13:50:43.632Z]  golang.org/x/net v0.0.0-20200202094626-16171245cfb2 h1:CCH4IOTTfewWjGOlSp+zGcjutRKlBEZQ6wTn8ozI/nI=
[2020-03-05T13:50:43.632Z]  golang.org/x/net v0.0.0-20200202094626-16171245cfb2/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
[2020-03-05T13:50:43.632Z] +golang.org/x/net v0.0.0-20200226121028-0de0cce0169b h1:0mm1VjtFUOIlE1SbDlwjYaDxZVDP2S5ou6y0gSgXHu8=
[2020-03-05T13:50:43.632Z] +golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
[2020-03-05T13:50:43.632Z]  golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
[2020-03-05T13:50:43.632Z]  golang.org/x/oauth2 v0.0.0-20181106182150-f42d05182288/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
[2020-03-05T13:50:43.632Z]  golang.org/x/oauth2 v0.0.0-20190130055435-99b60b757ec1/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
[2020-03-05T13:50:43.632Z] @@ -741,6 +745,8 @@ golang.org/x/sys v0.0.0-20191204072324-ce4227a45e2e/go.mod h1:h1NjWce9XRLGQEsW7w
[2020-03-05T13:50:43.632Z]  golang.org/x/sys v0.0.0-20191228213918-04cbcbbfeed8/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
[2020-03-05T13:50:43.632Z]  golang.org/x/sys v0.0.0-20200102141924-c96a22e43c9c h1:OYFUffxXPezb7BVTx9AaD4Vl0qtxmklBIkwCKH1YwDY=
[2020-03-05T13:50:43.632Z]  golang.org/x/sys v0.0.0-20200102141924-c96a22e43c9c/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
[2020-03-05T13:50:43.632Z] +golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527 h1:uYVVQ9WP/Ds2ROhcaGPeIdVq0RIXVLwsHlnvJ+cT1So=
[2020-03-05T13:50:43.632Z] +golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
[2020-03-05T13:50:43.632Z]  golang.org/x/text v0.0.0-20160726164857-2910a502d2bf/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
[2020-03-05T13:50:43.632Z]  golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
[2020-03-05T13:50:43.632Z]  golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
[2020-03-05T13:50:43.632Z] @@ -771,9 +777,12 @@ golang.org/x/tools v0.0.0-20190628153133-6cdbf07be9d0/go.mod h1:/rFqwRUd4F7ZHNgw
[2020-03-05T13:50:43.632Z]  golang.org/x/tools v0.0.0-20190816200558-6889da9d5479/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
[2020-03-05T13:50:43.632Z]  golang.org/x/tools v0.0.0-20190911174233-4f2ddba30aff/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
[2020-03-05T13:50:43.632Z]  golang.org/x/tools v0.0.0-20191012152004-8de300cfc20a/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
[2020-03-05T13:50:43.632Z] +golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
[2020-03-05T13:50:43.632Z]  golang.org/x/tools v0.0.0-20191125144606-a911d9008d1f/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
[2020-03-05T13:50:43.632Z]  golang.org/x/tools v0.0.0-20191227053925-7b8e75db28f4 h1:Toz2IK7k8rbltAXwNAxKcn9OzqyNfMUhUNjz3sL0NMk=
[2020-03-05T13:50:43.633Z]  golang.org/x/tools v0.0.0-20191227053925-7b8e75db28f4/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28=
[2020-03-05T13:50:43.633Z] +golang.org/x/tools v0.0.0-20200304193943-95d2e580d8eb h1:iKlO7ROJc6SttHKlxzwGytRtBUqX4VARrNTgP2YLX5M=
[2020-03-05T13:50:43.633Z] +golang.org/x/tools v0.0.0-20200304193943-95d2e580d8eb/go.mod h1:o4KQGtdN14AW+yjsvvwRTJJuXz8XRtIHtEnmAXLyFUw=
[2020-03-05T13:50:43.633Z]  golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
[2020-03-05T13:50:43.633Z]  golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
[2020-03-05T13:50:43.633Z]  golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
[2020-03-05T13:50:43.633Z] @@ -843,6 +852,8 @@ gopkg.in/yaml.v2 v2.2.4 h1:/eiJrUcujPVeJ3xlSWaiNi3uSVmDGBK1pDHUHAnao1I=
[2020-03-05T13:50:43.633Z]  gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
[2020-03-05T13:50:43.633Z]  gopkg.in/yaml.v2 v2.2.7 h1:VUgggvou5XRW9mHwD/yXxIYSMtY0zoKQf/v226p2nyo=
[2020-03-05T13:50:43.633Z]  gopkg.in/yaml.v2 v2.2.7/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
[2020-03-05T13:50:43.633Z] +gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
[2020-03-05T13:50:43.633Z] +gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
[2020-03-05T13:50:43.633Z]  gotest.tools v2.2.0+incompatible h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
[2020-03-05T13:50:43.633Z]  gotest.tools v2.2.0+incompatible/go.mod h1:DsYFclhRJ6vuDpmuTbkuFWG+y2sxOXAzmJt81HFBacw=
[2020-03-05T13:50:43.633Z]  honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
[2020-03-05T13:50:43.633Z] go.mod: needs update
[2020-03-05T13:50:43.633Z] go.sum: needs update
[2020-03-05T13:50:43.633Z] Makefile:86: recipe for target 'check' failed
[2020-03-05T13:50:43.633Z] make: *** [check] Error 1
@kuisathaverat
Copy link
Contributor Author

After investigating the issue the culprit is a command that we executed before go get -u github.com/kardianos/govendor this command update some modules version in the go.mod file causing the error.

see golang/go#27643

@kuisathaverat kuisathaverat self-assigned this Mar 5, 2020
@kuisathaverat kuisathaverat mentioned this issue Mar 5, 2020
Merged
@andresrc
Copy link
Contributor

andresrc commented Mar 9, 2020

@kuisathaverat can we close this?

@kuisathaverat
Copy link
Contributor Author

yes it is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuisathaverat kuisathaverat

Labels
automation ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andresrc @kuisathaverat