Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: unify test helpers #18239

Closed
ycombinator opened this issue May 5, 2020 · 2 comments
Closed

Cleanup: unify test helpers #18239

ycombinator opened this issue May 5, 2020 · 2 comments
Labels

Comments

@ycombinator
Copy link
Contributor

Sometimes we need testing utilities that can be shared across packages. For example, see the SeedPRNG function.

Ideally, we'd be able to place such utilities in a _test.go file so they are not compiled into the production binary. However, this is not possible in golang.

The next best option seems to be using an internal package. To this end, we now have a beats/libbeat/internal folder. Any code that should be usable by packages rooted at beats/libbeat but not by packages outside it should go in here. This includes test helpers/utilities such as the aforementioned SeedPRNG function.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
@ycombinator ycombinator added Team:Integrations Label for the Integrations team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic
Copy link

botelastic bot commented Apr 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Apr 12, 2021
@botelastic botelastic bot closed this as completed May 12, 2021
@zube zube bot removed the [zube]: Done label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants