Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Unable to get account id in China regions #18850

Closed
henrysher opened this issue May 29, 2020 · 2 comments · Fixed by #19423
Closed

[Metricbeat] Unable to get account id in China regions #18850

henrysher opened this issue May 29, 2020 · 2 comments · Fixed by #19423
Labels
enhancement Team:Platforms Label for the Integrations - Platforms team

Comments

@henrysher
Copy link

henrysher commented May 29, 2020

The hardcoded region here "us-east-1" works well in global regions but not for China regions.

x-pack/metricbeat/module/aws/aws.go
@@ -86,7 +87,9 @@ func NewMetricSet(base mb.BaseMetricSet) (*MetricSet, error) {
	}

	// Get IAM account name
	svcIam := iam.New(awsConfig)
	awsConfig.Region = "us-east-1"

Furthermore, I have changed "us-east-1" to "cn-north-1" and re-compiled in both China regions: Beijing and Ningxia, it works well.

So, i would suggest to add a new variable to configure by users.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 29, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label May 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 29, 2020
@kwinstonix
Copy link
Contributor

Is there any progress on this issue ?

A config param aws_partition could indicate the aws account type.

https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html

The following are the supported partitions:

aws - AWS Regions

aws-cn - AWS China Regions

aws-us-gov - AWS GovCloud (US) Regions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants