Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] S3 input module should trim the delimiter of log line #19853

Closed
kwinstonix opened this issue Jul 13, 2020 · 2 comments · Fixed by #19972
Closed

[Filebeat] S3 input module should trim the delimiter of log line #19853

kwinstonix opened this issue Jul 13, 2020 · 2 comments · Fixed by #19972
Assignees
Labels
bug Team:Platforms Label for the Integrations - Platforms team

Comments

@kwinstonix
Copy link
Contributor

  • Bug

For confirmed bugs, please report:

  • Version: 7.8.0

Here log contains delimiter \n, so each event message filed also has \n.

I think It is better to trim \n, just like the behavior of reading log files

// handle s3 objects that are not json content-type
offset := 0
for {
log, err := reader.ReadString('\n')
if log == "" {
break
}
if err == io.EOF {
// create event for last line

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Jul 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@exekias exekias added the bug label Jul 14, 2020
@exekias
Copy link
Contributor

exekias commented Jul 14, 2020

This looks reasonable to me, I think this is what we do for all the other inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants