Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate metricsets in aws module to use cloudwatch input as lightweight module #21422

Closed
5 of 6 tasks
kaiyan-sheng opened this issue Sep 30, 2020 · 5 comments
Closed
5 of 6 tasks
Assignees
Labels
meta size/XL Team:Platforms Label for the Integrations - Platforms team

Comments

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Sep 30, 2020

In aws module we have several metricsets that are not lightweight modules. This issue is to track the work for converting them into lightweight modules. There are some problems we are facing:

  1. Some metricsets are not only calling CloudWatch API. For example, billing metricset is also making CostExplorer API and ec2 metricset is also making DescribeInstances API.
  1. How to keep backwards compatibility with metric names. For example, after using lightweight module, aws.ec2.cpu.total.pct will be aws.ec2. CPUUtilization.avg. @jsoriano suggested that fields can be renamed using processors. This will be a good option to keep both names instead of making a breaking change.

This is a meta issue to track the work for migrating all listed metricsets above to use lightweight modules.

cc: @exekias @jsoriano @sorantis

@kaiyan-sheng kaiyan-sheng self-assigned this Sep 30, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Sep 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@kaiyan-sheng
Copy link
Contributor Author

Migrate ec2 metricset: #25924

@kaiyan-sheng
Copy link
Contributor Author

Migrate rds metricset: #26077

@kaiyan-sheng
Copy link
Contributor Author

Migrate sqs metricset: #26117

@kaiyan-sheng
Copy link
Contributor Author

Update: For ec2, rds and sqs, we are adding metadata from separate API calls into the events that are populated from CloudWatch API response. billing metricset in aws module is not the same as other metricsets because it is not adding metadata into the same events. Instead, billing is creating two sets of events: from CloudWatch and from Cost Explorer.
I will keep billing metricset as it is for now. Maybe we should think about separating billing into its separate module in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta size/XL Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

3 participants