-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Initialize processors in manifest.yml with TestData function #21817
Comments
Pinging @elastic/integrations-platforms (Team:Platforms) |
After this is done, I will rerun |
I have been investigating this issue and I think that the solution is not very straigth-forward. The thing is that So to be able to use the
First option would be a bit tricky because it wouldn't be testing the real pipelines, but it would serve to generate the For testing, there is an alternative, pipelines are executed in system tests, maybe we can use them to generate the I have pushed my tests here: master...jsoriano:lightmodules-processors-test As there is a possible workaround with system tests, I am not sure if it worths the effort. In any case I will give a quick try to make the helpers aware of light modules processors. @kaiyan-sheng do you think that system tests may work in your case? |
@jsoriano Thank you for the investigation! Yes if system tests can generate data.json for light modules with processors, that's fine for me! |
Finally I tried this, and it seems to work well, PR open: #22854 |
Describe the enhancement:
For light weight modules, sometimes we have processors defined in manifest.yml file. But the processors are not initialized when running
TestData
function in integration test file to generatedata.json
.For example: with the rename processor
beats/x-pack/metricbeat/module/aws/s3_daily_storage/manifest.yml
Line 14 in 7d78d64
we should see different names for the fields in the data.json file generate by
TestData
function ins3_daily_storage_integration_test.go
:beats/x-pack/metricbeat/module/aws/s3_daily_storage/_meta/data.json
Line 13 in 7d78d64
Link: #21703 (comment)
cc @jsoriano
The text was updated successfully, but these errors were encountered: