Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default HTTP User Agent string #21975

Closed
urso opened this issue Oct 19, 2020 · 5 comments
Closed

Default HTTP User Agent string #21975

urso opened this issue Oct 19, 2020 · 5 comments
Labels
enhancement Team:Services (Deprecated) Label for the former Integrations-Services team

Comments

@urso
Copy link

urso commented Oct 19, 2020

The default user agent string for HTTP requests by Beats is Go-http-client/1.1. The string is set by the go stdlib: https://github.com/golang/go/blob/606d4a38b9ae76df30cc1bcaeee79923a5792e59/src/net/http/request.go#L512

For Beats we should have a more complete string, that contains the product name+version, the libbeat version, to go version, and OS. For example: <Beatname> <version> (<os+arch-string>, libbeat: <version>, go: <version>).

@urso urso added enhancement Team:Services (Deprecated) Label for the former Integrations-Services team labels Oct 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@kvch
Copy link
Contributor

kvch commented Oct 19, 2020

We could use the existing User agent generator: https://github.com/elastic/beats/blob/master/libbeat/common/useragent/useragent.go#L29

@botelastic
Copy link

botelastic bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Sep 19, 2021
@andrewkroh
Copy link
Member

IIUC this has been implemented by @michel-laterman in #27509 and will be present in 7.16.0? @michel-laterman, can you confirm and close?

@botelastic botelastic bot removed the Stalled label Oct 11, 2021
@michel-laterman
Copy link
Contributor

yes, sorry about the delay this item should already be handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

No branches or pull requests

5 participants