Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider copying kubernetes.node.hostname to host.name #22519

Closed
ChrsMark opened this issue Nov 10, 2020 · 4 comments
Closed

Consider copying kubernetes.node.hostname to host.name #22519

ChrsMark opened this issue Nov 10, 2020 · 4 comments
Assignees
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team Team:Platforms Label for the Integrations - Platforms team

Comments

@ChrsMark
Copy link
Member

Follow up of #22189 (comment)

We need to evaluate if kubernetes.node.hostname added at #22189 can be copied at host.name. Some testing need to take place in that case to verify that what is added is expected in that case as well what will happen if add_host_metadata is enabled at the same time.

Related to https://github.com/elastic/integrations-dev/issues/385, #20434

cc: @jsoriano @kaiyan-sheng @exekias

@ChrsMark ChrsMark added the Team:Platforms Label for the Integrations - Platforms team label Nov 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ChrsMark
Copy link
Member Author

@jsoriano After reading #20434 again and running Metricbeat on GKE to test it I see the following:
Screenshot 2022-02-22 at 10 42 04 AM

It seems that kubernetes.node.name and host.name is the same while the kubernetes.node.hostname is actually different.

I guess that the main point of #20434 was to suggest using kubernetes.node.hostname in place of host.name (copy) as a more representative value, right? Just want to verify if this theory align with what we see in this example above?

@jsoriano
Copy link
Member

Let's close this by now as it doesn't seem to be causing specific problems now, we can reopen later if we find specific use cases that need improvements.

@ChrsMark
Copy link
Member Author

A note about ECS compatibility:

In this case, we can place the FQDN into host.name and use host.hostname for the value returned by hostname on the system (or returned from API).
Idea being that host.hostname represents what the server defines itself as but host.name is more of an accurate identity decided by the implementor. host.name is meant to only hold one value.

Leaving it here as reference for the future but we will need it to validate it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

3 participants