Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NaNs in Cloud Foundry metrics #22599

Closed
jsoriano opened this issue Nov 16, 2020 · 1 comment · Fixed by #22634
Closed

Handle NaNs in Cloud Foundry metrics #22599

jsoriano opened this issue Nov 16, 2020 · 1 comment · Fixed by #22634
Assignees
Labels
bug Team:Platforms Label for the Integrations - Platforms team

Comments

@jsoriano
Copy link
Member

jsoriano commented Nov 16, 2020

There have been reports of Metricbeats using the cloudfoundry module only, that log errors like these ones:

ERROR   [publisher_pipeline_output]     pipeline/output.go:180  failed to publish events: unsupported float value: NaN
ERROR   [logstash]      logstash/async.go:280   Failed to publish events caused by: unsupported float value: NaN
DEBUG   [logstash]      logstash/enc.go:37      Failed to encode event: &{2020-11-16 15:50:08.877478995 +0100 CET {} Not valid json: json: error calling MarshalJSON for type common.Float: invalid character 'N' looking for beginning of value <nil> true}

That seem to indicate that there is a problem like #10849, but in the cloudfoundry module.

As we did with Prometheus in #12084, we may also need to add some defensive code around float values received from the Firehose.

Floats can be received from the Firehose in envelopes of type value (Value field) and in container metrics (CpuPercentage), objects in the firehose are encoded using protobuf, that supports NaN values.

For confirmed bugs, please report:

  • Version: 7.7.1, 7.10.0
  • Steps to Reproduce: Use the cloudfoundry module (not clear with what metrics).
@jsoriano jsoriano added bug Team:Platforms Label for the Integrations - Platforms team labels Nov 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants