Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config parsing for disable_host to FunctionBeat #30673

Closed
msluther opened this issue Mar 3, 2022 · 4 comments
Closed

Add config parsing for disable_host to FunctionBeat #30673

msluther opened this issue Mar 3, 2022 · 4 comments
Labels

Comments

@msluther
Copy link

msluther commented Mar 3, 2022

Describe the enhancement:

This PR was merged May 2020:
#18159

That means there is now logic in libbeats to be able to skip adding host: { name } into the output. The option to configure this should get pulled into functionbeat as well as filebeat (perhaps other beats as well?)

Describe a specific use case for the enhancement or feature:

FunctionBeats run as a serverless function. In AWS this means a Lambda that runs and processes some input pipe of events. The host that gets written by functionbeat ends up being the host running the serverless function and not the host that wrote the source event. Having the ability to skip this incorrect data being written into our system is fairly imperative. It also makes it easier to find any events being created that aren't conforming to ECS and are missing host.name so that those events could be fixed.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2022
@mtojek mtojek added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 21, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2022
@botelastic
Copy link

botelastic bot commented Mar 21, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 21, 2023
@msluther
Copy link
Author

👍

@botelastic botelastic bot removed the Stalled label Mar 21, 2023
@botelastic
Copy link

botelastic bot commented Mar 20, 2024

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 20, 2024
@botelastic botelastic bot closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants