Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Add timeout to browser monitors in HB side #32388

Closed
emilioalvap opened this issue Jul 18, 2022 · 2 comments · Fixed by #32434
Closed

[Heartbeat] Add timeout to browser monitors in HB side #32388

emilioalvap opened this issue Jul 18, 2022 · 2 comments · Fixed by #32434
Assignees
@emilioalvap
Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@emilioalvap
Copy link
Collaborator

emilioalvap commented Jul 18, 2022 •
edited by zube bot
Loading

Describe the enhancement:

Add a configurable timeout for synthetic monitors, in case node process goes unresponsive. This timeout will be used from HB to kill synthetic monitor's in case node goes unresponsive, as seen in #32387. HB will wait for node process to exit and will proceed to kill it with SIGKILL if it doesn't do it before timeout is reached.

Additionaly, a sensible default should be used so this timeout can kick in before container eviction timeout inside synthetics service. @andrewc suggested ~14 min.

ACs:

  • Timeout is configurable from heartbeat.yml.
  • Test run is marked as failed if timeout is reached and appropriate summary is included in the monitor run.
@emilioalvap emilioalvap added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jul 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@emilioalvap emilioalvap mentioned this issue Jul 18, 2022
Closed
@vigneshshanmugam vigneshshanmugam mentioned this issue Jul 18, 2022
Closed
@emilioalvap emilioalvap self-assigned this Jul 19, 2022
@emilioalvap emilioalvap mentioned this issue Jul 21, 2022
Merged
6 tasks
@vigneshshanmugam vigneshshanmugam self-assigned this Aug 1, 2022
@vigneshshanmugam
Copy link
Member

POST FF testing LGTM
Screen Shot 2022-08-01 at 11 42 40 AM

@vigneshshanmugam vigneshshanmugam removed their assignment Aug 1, 2022
@paulb-elastic paulb-elastic mentioned this issue Aug 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilioalvap emilioalvap

Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Add browser monitor timeout emilioalvap/beats
3 participants
@vigneshshanmugam @elasticmachine @emilioalvap