Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Prometheus and Openmetrics codebase #34334

Closed
ChrsMark opened this issue Jan 23, 2023 · 1 comment
Closed

Improve Prometheus and Openmetrics codebase #34334

ChrsMark opened this issue Jan 23, 2023 · 1 comment
Labels
Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Jan 23, 2023

After adding textparse library with #33865 and we have verified it doesn't break any functionality we can further improve our codebase and organize the helper libs in a better way. Some suggestions:

  1. Use interface at: Use textparse in prometheus module helper library #33865 (comment)
  2. Split codeflow in smaller functions: Use textparse in prometheus module helper library #33865 (comment)
  3. Look for duplicated implementations between Prometheus and Openmetrics helper libs and consider abstracting them into a common helper lib.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 23, 2023
@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Jan 23, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 23, 2023
@botelastic
Copy link

botelastic bot commented Jan 23, 2024

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 23, 2024
@botelastic botelastic bot closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

No branches or pull requests

1 participant