Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include selector name in debug output #5042

Closed
Tracked by #5000
roncohen opened this issue Aug 29, 2017 · 3 comments
Closed
Tracked by #5000

Include selector name in debug output #5042

roncohen opened this issue Aug 29, 2017 · 3 comments

Comments

@roncohen
Copy link
Contributor

It would be useful if the debug output included the selector name so you the selector for each log line and you can more easily update your -d filter to include/exclude them:

This:

2017/08/29 09:13:28.898295 server.go:85: DBG Request: URI=/v1/errors, method=POST, content-length=156

would be

2017/08/29 09:13:28.898295 server.go:85: DBG handler Request: URI=/v1/errors, method=POST, content-length=156

if the call was

logp.Debug("handler", "Request...")

Potential alternatives are:

2017/08/29 09:13:28.898295 server.go:85: DBG/handler Request: URI=/v1/errors, method=POST, content-length=156
2017/08/29 09:13:28.898295 server.go:85: DBG:handler Request: URI=/v1/errors, method=POST, content-length=156
@exekias
Copy link
Contributor

exekias commented Aug 29, 2017

+1, linked it with #5000

@andrewkroh
Copy link
Member

How about DBG [selector]? I've been using this in Auditbeat (and I think in a few places in Metricbeat).

2017/08/29 09:13:28.898295 server.go:85: DBG [handler] Request: URI=/v1/errors, method=POST, content-length=156

@roncohen
Copy link
Contributor Author

@andrewkroh I like that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants