Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POD_NAMESPACE setting from kubernetes manifests #5501

Closed
exekias opened this issue Nov 2, 2017 · 4 comments
Closed

Remove POD_NAMESPACE setting from kubernetes manifests #5501

exekias opened this issue Nov 2, 2017 · 4 comments
Labels
docs Filebeat Filebeat good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat

Comments

@exekias
Copy link
Contributor

exekias commented Nov 2, 2017

It's no longer needed since #5482 autodetects it, we can now remove POD_NAMESPACE env var, and namespace key under config: https://github.com/elastic/beats/blob/master/deploy/kubernetes/filebeat/filebeat-daemonset.yaml#L34

@exekias exekias added docs Filebeat Filebeat Metricbeat Metricbeat good first issue Indicates a good issue for first-time contributors labels Nov 2, 2017
@liketic
Copy link

liketic commented Nov 22, 2017

Hi @exekias So we need to remove POD_NAMESPACE and metadata.namespace in kubernetes module? Thanks!

@exekias
Copy link
Contributor Author

exekias commented Nov 22, 2017

No need to update code on this one, this is about testing this still works after removing these lines

- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace

I was planning to do this in the following days 😄

@palash25
Copy link

Is anyone working on this? If not then I would like to take this up.

@exekias
Copy link
Contributor Author

exekias commented Mar 11, 2018

Thank you for volunteering @palash25! I'm afraid I did the job some time ago, but forgot to update this issue. I'm sorry for that 😞

This was fixed by #5963, thank you for bringing this up, I think we can close it now

@exekias exekias closed this as completed Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Filebeat Filebeat good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat
Projects
None yet
Development

No branches or pull requests

3 participants