Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors for 7.0 (Breaking changes I want to make) #6106

Closed
13 of 20 tasks
andrewkroh opened this issue Jan 18, 2018 · 16 comments
Closed
13 of 20 tasks

Refactors for 7.0 (Breaking changes I want to make) #6106

andrewkroh opened this issue Jan 18, 2018 · 16 comments
Assignees
Labels
discuss Issue needs further discussion. meta v7.0.0

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Jan 18, 2018

This is a running list of things to consider changing for 7.0. Feel free to add your own with attribution.

Would be nice to have

@andrewkroh andrewkroh added the discuss Issue needs further discussion. label Jan 18, 2018
@ruflin ruflin added the meta label Jan 21, 2018
@ruflin ruflin mentioned this issue Jun 28, 2018
@ph
Copy link
Contributor

ph commented Aug 6, 2018

Added #7881

@jsoriano
Copy link
Member

jsoriano commented Nov 2, 2018

I have added a point to make beats log to journald by default when running on systemd, open to discussion, I'll open a PR.

@exekias I have added also a point about dedoting labels so we don't forget about this.

@ruflin
Copy link
Member

ruflin commented Nov 5, 2018

I added a point about removing the 5.x dashboard directories to the above list. We should probably add a directory for 7 as the data structure for Kibana will change. @elastic/apm-server This might also effect you.

I put it on the service meeting agenda today.

@ph ph self-assigned this Nov 5, 2018
@ph
Copy link
Contributor

ph commented Nov 5, 2018

@jsoriano

I have added a point to make beats log to journald by default when running on systemd, open to discussion, I'll open a PR.

Can you create an issue for that, I don't know how big of a task it is.

@ph
Copy link
Contributor

ph commented Nov 5, 2018

@ruflin I believe your ECS migration will take care of: Default Template Mappings for IP fields are keyword type #7847

@ph
Copy link
Contributor

ph commented Nov 5, 2018

@urso @ruflin @exekias I have added your name to the list of items you have added to this list, feel free to either remove the items or delegate the work.

@ruflin
Copy link
Member

ruflin commented Nov 6, 2018

The IP stuff is not directly related to ECS but parts of it might be resolved through ECS.

@jsoriano
Copy link
Member

jsoriano commented Nov 6, 2018

@ph for the systemd unit logging to journald I mean something like #8942

@ph
Copy link
Contributor

ph commented Nov 6, 2018

FYI I've added the following methods to fails on removed options, if you want to provide better feedback use them and it make it easy for us to remove them in 8.0.

// CheckRemoved6xSettings prints a warning if the obsolete setting is used.
func CheckRemoved6xSettings(cfg *common.Config, settings ...string) error {
return checkRemovedSettings(cfg, settings...)
}
// CheckRemoved6xSetting prints a warning if the obsolete setting is used.
func CheckRemoved6xSetting(cfg *common.Config, setting string) error {
return checkRemovedSetting(cfg, setting)
}

@urso
Copy link

urso commented Nov 20, 2018

recent changes:

@elasticmachine
Copy link
Collaborator

Pinging @elastic/infrastructure

@alvarolobato alvarolobato removed Team:Integrations Label for the Integrations team labels Dec 3, 2018
@ph
Copy link
Contributor

ph commented Dec 6, 2018

Added a note about _xpack's rest endpoint deprecation #9424

@urso
Copy link

urso commented Apr 17, 2019

I think we can close this one.

@andrewkroh @ruflin @ph @kaiyan-sheng @kvch @jsoriano Any of the items mentioned still open?

@jsoriano
Copy link
Member

I didn't check if we should change some potentially big gauges from long to float, but I think this wouldn't be so breaking.

@kaiyan-sheng
Copy link
Contributor

Nothing open on my side 👍For dedot we do have #10773 to track some cleanup work.

@urso
Copy link

urso commented Aug 15, 2019

Not sure if all check boxes can be ticked off. But 7.0 is out for quite a while. Closing this.

@urso urso closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. meta v7.0.0
Projects
None yet
Development

No branches or pull requests

8 participants