Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields.yml is ignored but still shipped with packages #8607

Closed
roncohen opened this issue Oct 12, 2018 · 3 comments
Closed

fields.yml is ignored but still shipped with packages #8607

roncohen opened this issue Oct 12, 2018 · 3 comments
Labels
good first issue Indicates a good issue for first-time contributors libbeat Stalled Team:Integrations Label for the Integrations team

Comments

@roncohen
Copy link
Contributor

For 6.4 and possibly earlier versions, fields.yml is embedded in the binaries. fields.yml is still included in packages, but is ignored.
Looks like #setup.template.fields: "${path.config}/fields.yml" should be on by default

@andrewkroh
Copy link
Member

I agree this is a bit confusing if you ever try to modify the fields.yml.

@ruflin How do you want to handle this?

@ruflin
Copy link
Contributor

ruflin commented Oct 13, 2018

The change was made in #4834 I remember the thinking around setting it off by default was that previously we didn't document / recommend to modify fields.yml so it was not considered breaking change.

Long term I'm thinking the fields.yml should be removed and for modifications append_fields should be used. There should be an option to export the fiel for modifications if needed and then load it. So I like the current behaviour that it's not default but I see the point that it's confusing in case of modifications. Should we add better docs around it so we can at least point users to it?

@botelastic
Copy link

botelastic bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Feb 4, 2021
@botelastic botelastic bot closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Indicates a good issue for first-time contributors libbeat Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

5 participants