Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorizations in metricbeat redis module #9678

Closed
4 tasks
jsoriano opened this issue Dec 19, 2018 · 0 comments · Fixed by #9907
Closed
4 tasks

Refactorizations in metricbeat redis module #9678

jsoriano opened this issue Dec 19, 2018 · 0 comments · Fixed by #9907
Assignees
@jsoriano
Labels
Metricbeat Metricbeat module refactoring Team:Integrations Label for the Integrations team

Comments

@jsoriano
Copy link
Member

jsoriano commented Dec 19, 2018 •
edited
Loading

In #9657 we identified some possible refactorizations:

  • Reuse common configuration
  • Reuse code to create new pools
  • Ensure that connections are closed when metricsets are stopped
  • Add tests for untested common methods in the redis module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsoriano jsoriano

Labels
Metricbeat Metricbeat module refactoring Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metricbeat redis refactors jsoriano/beats
1 participant
@jsoriano