Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reducing webhook timeout #2563

Open
anyasabo opened this issue Feb 13, 2020 · 1 comment
Open

Consider reducing webhook timeout #2563

anyasabo opened this issue Feb 13, 2020 · 1 comment
Labels
discuss We need to figure this out min-k8s-ver:1.14

Comments

@anyasabo
Copy link
Contributor

Follow up from:
#1634

With the 30s timeout in the webhook config and the 30s timeout in clients, it seems like we may want to reduce the validating webhook configuration timeoutSeconds to less than 30s. Kubectl clients and the operator can fail to update ES resources. I wonder if we should reduce it to 10s (or maybe even less?)? The validations run quite quickly so we should be able to process them all in much less than 30s, and if the network is misconfigured such that the webhook times out, at least the clients do not time out and can proceed.

I worry a little bit that this is a bandaid over a problem, but it seems like changing this would allows the webhook to "fail open" rather than closed, which seems like a benefit.

I also wonder if we want to make a docs section about "working with my elastic resources is slow" and point them to webhook troubleshooting.

Also reference:
https://discuss.elastic.co/t/elastic-operator-requests-regularly-time-out/219096
#2545

@anyasabo anyasabo added the discuss We need to figure this out label Feb 13, 2020
@anyasabo
Copy link
Contributor Author

Ah I remembered why we did not do this earlier, the timeout field was only introduced in 1.14:
kubernetes/kubernetes#74562

You can apply it in earlier versions, but client-side validation in kubectl will error out. You need to pass --validate=false for kubectl apply to work.

Should we keep this open pending us dropping support for <1.14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss We need to figure this out min-k8s-ver:1.14
Projects
None yet
Development

No branches or pull requests

1 participant