Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secret hash instead of resource version to recreate pods when updating secure settings secrets #7842

Closed
thbkrkr opened this issue May 23, 2024 · 0 comments · Fixed by #7843
Labels
>bug Something isn't working sdh

Comments

@thbkrkr
Copy link
Contributor

thbkrkr commented May 23, 2024

Problem: If an external tool updates the -es-secure-settings- Secret resource version without updating the Secret data, the operator restarts the Elasticsearch nodes.

Cause: When using secure settings Secrets, the operator uses the resource version of the Secrets to compute the final hash set on the Elasticsearch pods label in order to recreate Pods when the Secret changes.

// resource version will be included in pod labels,
// to recreate pods on any secret change.
resourceVersion := secret.GetResourceVersion()

Proposal: use a hash of the Secret data instead of the resource version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working sdh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant