elasticsearch default /usr/local/elasticsearch is no good for elasticsearch-env.sh

[mythicalprogrammer]

There a few people having problem with the default and getting this error:

You must set the ES_CLASSPATH var

The problem is the default is installation path is /usr/local/elasticsearch

Why is this a problem?

Well looking in vim /usr/local/bin/elasticsearch

71 # If an include wasn't specified in the environment, then search for one...
72 if [ "x$ES_INCLUDE" = "x" ]; then
73 # Locations (in order) to use when searching for an include file.
74 for include in /usr/share/elasticsearch/elasticsearch.in.sh
75 /usr/local/share/elasticsearch/elasticsearch.in.sh
76 /opt/elasticsearch/elasticsearch.in.sh
77 ~/.elasticsearch.in.sh \

74 to 77 are the default locations where it expect elasticsearch-env.sh is at.

It doesn't expect it to be in /usr/local/bin/elasticsearch

I believe the solution is check if it's a deb flavor linux and change the default to /usr/share/elasticsearch which what their .deb does anyway. I'm not entirely sure if this affect any other flavor linux such as rpm.

[karmi]

You can install ES in whatever location is appropriate -- just set the relevant paths in node attributes.

The "include" file is renamed in the cookbook anyway.