-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ES 2.0 #384
Comments
Has this been addressed in 2.0.0_wip? voxpupuli/puppet-elasticsearch#472 |
Hi @paulschwarz. We moved to using the same init scripts and files as the packages shipped from elasticsearch.org, as of RC1 of ES 2.0. If it's fixed there, we should be fixed as well. We can check that before we release as well, based on the comments in this issue. |
@martinb3 I was going to try updating it for 2.0 (non RC) but then I notice that we are using sha256 for the checksums I am looking here: https://www.elastic.co/downloads/past-releases/elasticsearch-2-0-0 and they appear to be given as sha1. Is there somewhere else you have been grabbing them from? |
@majormoses I have been downloading the binaries to calculate them, as Chef's resources are all based on sha256 checksums and not sha1. If we provide a sha1 to chef, it will just re-download over and over. Hope this helps, - Martin |
Is there an ETA on a 2.0.0 (non rc)? On Mon, 2 Nov 2015, 23:58 Martin Smith notifications@github.com wrote:
|
@paulschwarz I haven't really had any testing feedback yet. If anyone could send feedback on the cookbook's 2.0.0_wip branch, I would be much obliged! :) It also looks like maybe we should grab the newest init scripts from the packages, since some updates were made in ES 2.0.0. |
@martinb3 bumping it to 2.0 and going to start testing it |
I am looking into it but elasticsearch is definitely broken despite converging. I am still looking for root cause. When I try to start the service it says its starting but there is nothing being logged. the process immediately dies. I am starting it manually and see this:
I have manually attempted to set the follwoing in /etc/security/limits.conf and rebooting and verified it was was working:
|
We'll need to look into what the packages do; the cookbook used to set limits, but we saw the 1.x packages weren't; in an effort to match parity between the packages and chef, we removed it. |
@martinb3 I spun up a brand new cluster to test with as opposed to an upgrade (so there apparently is not a nice upgrade path even if you run the plugin first). I am able to get the process to launch without errors manually but the init scripts are still failing with no logging. I will report back what I find.
|
@martinb3 also I forgot to mention but I bumped my java to 8 where previously it was 7. |
interesting I am now seeing no route to host errors even though I can ping myself just fine:
dns resolution and basic connectivity;
|
my config that chef outputs: http://pastebin.com/WCxHkRi1 |
@martinb3 Found why the init script is broken: elastic/elasticsearch#13772 |
I will see about fixing it |
Hi folks -- I have a pretty big changeset going I'm about to push as well, to |
Add new checksums and default to v2.0.0 of Elasticsearch. RE: #384.
Changes pushed to the |
I'll give feedback tomorrow morning, thanks for the effort! On Tue, 3 Nov 2015, 22:54 Martin Smith notifications@github.com wrote:
|
I have a quick and dirty non backwards compatible solution for the init script. I will work on getting it not so terrible... |
@martinb3 I have tested and the service starts though I am unable to get my cluster up. |
I dont see any communication between the nodes in the logs |
@martinb3 I got a cluster up. Two more settings I needed set that were new from previous versions of es:
They changed ES to only listen by default on local loopback. I am torn on whether those should be default as I would imagine 90% of people will want. But ES felt that they should set a new default so maybe I am missing something. |
@majormoses I hadn't run across that one yet. For the most part, I think the caller of the Chef resources should probably set those (using Chef search $clustering_solution, or w/e else they prefer) and we should just implement them. What do you think about deferring that as much as possible? I'm going for least surprise where-ever possible. |
@martinb3 maybe I am missing something but this is just setting the ES process binds and publish. Currently if we dont set it ES will default bind to 127.0.0.1 and ::1, I dont think is what most people expect, especially since in previous versions of ES I believe it bound to all interfaces. From your comment on chef search I think you may be referring to the unicast host list which yes I implement in my wrapper via a chef search via roles. Here is the doc that goes over what I am talking about: https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-network.html I am thinking that adding them to default attributes in here: https://github.com/elastic/cookbook-elasticsearch/blob/master/libraries/resource_configure.rb#L49-L67 and then it can be overwritable via: https://github.com/elastic/cookbook-elasticsearch/blob/master/libraries/resource_configure.rb#L72 would make sense to me, it was a gotcha for me to have to shell into the node to realize that it wasnt bound by the other interfaces like I expected. |
@majormoses I think most people expect the Chef cookbook to not fundamentally alter the defaults for Elasticsearch. This was one of the most common complaints before we re-wrote it to be nearer to the deb/rpm/package behaviors. If the Elasticsearch 2.0.0 defaults have significantly changed from 1.x to 2.x, I'm not sure the cookbook should change that for users. Most users expect us to default to the same defaults as a vanilla/package ES install. I'm not sure we know better than the Elasticsearch project what the defaults should be. If we adjust the ES defaults, we're likely to see people file issues here, such as, "I only have one node, Why are you changing the bind address from the ES default. I wasn't expecting that and now my ES instance in compromised." I feel like the ES defaults are both the most secure and the least surprise for folks coming to this cold. I feel like we can offer documentation on how to change things, for those who want to do so, to address all of the possible use cases. |
Thanks for the summary, @martinb3, I agree on the approach. |
@martinb3 fair enough. do you want to document it or would you like a PR? |
@majormoses I plan to document more, before the release, but I'd also welcome any PRs if you think there should be some specific language I shouldn't miss. Did everything else with the branch go okay? |
@martinb3 overall everything is standing up and working as far as I see. I haven't hooked an app up to it yet so I may uncover more later but I think we are probably good. I have not tested it since with an upgrade of a previous 1.x system so we should definitely do some testing there or at least call it out.... |
I've tried it out with a very minimal configuration on Ubuntu and it works. It installed 2.0.0 using the tarball. Great! |
Great job guys . I was able to install ES 2.0.0 using this cookbook on Amazon Linux AMI release 2014.09 , with one minor fix - |
@dvinograd that's great feedback; exactly what I was looking for; thank you! |
@dvinograd I've added the |
Does anyone have other comments on the 2.0.0_wip branch? I'd like to write a blog post to address #293 before we release. |
I cant think of anything else |
I'll put in a vote for some updated examples in the readme related #389 It would be nice if there were more examples guiding people down the packages route. As it stands, it is easy for a user to infer that the tarball installation is the recommend path. I'm willing to submit a pull request with what I think is a simple and clean recipe once I get my new cluster deployed. |
Hi all -- I've pushed some final updates to
|
According to this comment, packages are now the default install sous-chefs#384 (comment)
Version 2.0.0 of this cookbook has been released. |
Thank you all for your help!! |
Thanks Martin On Mon, 23 Nov 2015, 20:11 Martin Smith notifications@github.com wrote:
|
thanks, glad to be of help. |
💃 💃 💃 |
Currently in beta.
The text was updated successfully, but these errors were encountered: