Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Detection Rules Release Workflow is failing to successfully create and Integrations PR #3527

Closed
shashank-elastic opened this issue Mar 21, 2024 · 0 comments · Fixed by #3528 or #3552
Assignees
Labels
bug Something isn't working

Comments

@shashank-elastic
Copy link
Contributor

Describe the bug
The Release Workflow is failing with the below error.

TypeError: Repository.create_pull() takes 3 positional arguments but 5 positional arguments (and 2 keyword-only arguments) were given
Error: Process completed with exit code 1.

The recent upgrade to python 3.12 may have cause the arugment type error. Per the 3.12 docs the expected format would be

pr = repo.create_pull(
    base=base_branch,
    head=branch_name,
    title=message,
    body=body,
    maintainer_can_modify=True,
    draft=draft
)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Actions in detection-rules repo and then to Release fleet
  2. Click on Run workflow and supply a parameter per release steps here
  3. Issue Build
  4. See error

Expected behavior
A clear draft PR to the integrations repository

Workaround
At this step only the PR creation is failing. We can manually fetch the PR details from the build job and create them .
Not a blocker for release steps but some manual correlations are needed like sample below

remote: Create a pull request for 'detection-rules/8.10.14-beta.1-98170269' on GitHub by visiting:        
remote:      https://github.com/elastic/integrations/pull/new/detection-rules/8.10.14-beta.1-98170269     
@shashank-elastic shashank-elastic added the bug Something isn't working label Mar 21, 2024
@shashank-elastic shashank-elastic self-assigned this Mar 21, 2024
@shashank-elastic shashank-elastic added Area: DED fleet-release Issue tracking rule updates released to (OOB) Fleet integration package and removed fleet-release Issue tracking rule updates released to (OOB) Fleet integration package labels Mar 21, 2024
@shashank-elastic shashank-elastic linked a pull request Mar 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant