Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement Request] Make it possible to pass "support-diagnostics" parameters when running support diagnostics #191

Open
kunisen opened this issue Oct 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kunisen
Copy link

kunisen commented Oct 3, 2023

Per reading https://github.com/elastic/eck-diagnostics/blob/main/internal/stackdiag.go#L135-L156, it doesn't seem like we are able to pass "support-diagnostics" parameters, i.e. --bypassDiagVerify, --noVerify when running support diagnostics.

These 2 parameters are sometimes required to run support diagnostics. Per https://github.com/elastic/support-diagnostics,

  • --bypassDiagVerify: Turn off the internal check where the diagnostic queries Github to see if there is a newer version available. Useful in air gapped environments with no internet access. Default value is false.
  • --noVerify: Bypass hostname verification for the certificate when using the --ssl option. This can be unsafe in some cases, but can be used to bypass issues with an incorrect or missing hostname in the certificate. Default value is false.

While we understand we can run support diagnostics separately, it would be great if we could have a way to pass support-diagnostics related parameters when running support diagnostics, especially the above 2 options.

Thanks!

cc @maggieghamry @jguay

@kunisen kunisen added the enhancement New feature or request label Oct 3, 2023
@pebrc
Copy link
Collaborator

pebrc commented Oct 3, 2023

I would say we should probably always set --bypassDiagVerify to true

@kunisen
Copy link
Author

kunisen commented Oct 3, 2023

thanks @pebrc yeah, this is one we probably should encourage to set as it doesn't really harm anything and when it's air-gapped, it's always blocked...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants