Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Investigate use of vtprotobuf to generate the shipper gRPC API #263

Closed
Tracked by #16
cmacknz opened this issue Feb 28, 2023 · 2 comments
Closed
Tracked by #16

Investigate use of vtprotobuf to generate the shipper gRPC API #263

cmacknz opened this issue Feb 28, 2023 · 2 comments
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@cmacknz
Copy link
Member

cmacknz commented Feb 28, 2023

vtprotobuf is an alternative protobuf compiler that generates highly optimized unmarshalling code. It is an iteration on the widely used but now deprecated https://github.com/gogo/protobuf.

Investigate using the protoc-gen-go-vtproto protoc plugin to generate the code for both the client and server implementations in https://github.com/elastic/elastic-agent-shipper-client.

The outcome of this issue should be a proof of concept demonstrating that we can generate the gRPC code for the shipper using protoc-gen-go-vtproto with a measurable performance improvement over the standard protobuf compiler.

Note: We do not need to use vtprotobuf specifically if there is a better suited alternative that accomplishes the same goal of significantly improving the performance of generated code vs out of the box protoc.

@pierrehilbert
Copy link
Contributor

@cmacknz / @leehinman could we close this one with the new shipper plan?

@cmacknz
Copy link
Member Author

cmacknz commented May 4, 2023

This was done recently as part of #288 (comment).

Closing.

@cmacknz cmacknz closed this as completed May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants