Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set GOMAXPROCS #2423

Open
1 task
Tracked by #3640
cmacknz opened this issue Mar 30, 2023 · 1 comment
Open
1 task
Tracked by #3640

Automatically set GOMAXPROCS #2423

cmacknz opened this issue Mar 30, 2023 · 1 comment
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@cmacknz
Copy link
Member

cmacknz commented Mar 30, 2023

Describe the enhancement:
Automatically set GOMAXPROCS when beats are run in containers with a CFS quota set to minimize CPU throttling.

See elastic/apm-server#7967 and elastic/apm-server#8278 for more context. https://github.com/uber-go/automaxprocs can be used to easily add this feature.

Ideally this would be implemented for every agent subprocess:

Describe a specific use case for the enhancement or feature:
Setting GOMAXPROCS based on the configured CPU quota makes performance more predictable in containerized environments. Kubernetes deployments are particularly likely to experience problems from unoptimized GOMAXPROCS configurations.

@pierrehilbert
Copy link
Contributor

Removed elastic/elastic-agent-shipper#55 as no more part of the scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants