Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pprof init and mage code to elastic-agent-libs #276

Closed
fearful-symmetry opened this issue Mar 31, 2022 · 3 comments
Closed

Migrate pprof init and mage code to elastic-agent-libs #276

fearful-symmetry opened this issue Mar 31, 2022 · 3 comments
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.4.0

Comments

@fearful-symmetry
Copy link
Contributor

fearful-symmetry commented Mar 31, 2022

This is a continuation of an issue here elastic/elastic-agent-shipper#6 (comment) that I discussed with @ph .

Basically, as we start work on https://github.com/elastic/elastic-agent-shipper, there's a great deal of overlapping functionality with agent, but a lot of that functionality isn't importable and/or lives in internal/ Part of that is the pprof HTTP init process, which (among other functions) is setupMetrics in internal/pkg/agent/cmd/run.go. There's also the various config objects in internal/pkg/core/monitoring/config/config.go. It would be relatively nice if we could make these more generic and move them into the elastic-agent-libs library, where we can then import them back into agent and the shipper.

@fearful-symmetry fearful-symmetry added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team v8.3.0 labels Mar 31, 2022
@cmacknz cmacknz added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Apr 11, 2022
@cmacknz
Copy link
Member

cmacknz commented Apr 11, 2022

If we want to move elastic/elastic-agent-shipper#6 forward with this path we'll have to do this ourselves.

I've split the mage portion into a separate issue (#321) which I'll take care of.

@jlind23
Copy link
Contributor

jlind23 commented May 18, 2022

@fearful-symmetry is this something you will take care of? Just asking as you are assigned to it.

@jlind23 jlind23 added v8.4.0 and removed v8.3.0 labels May 18, 2022
@fearful-symmetry
Copy link
Contributor Author

@jlind23 yah, I think I'm going to close this, most of these issues ended up being dealt with indirectly or by other people. We can open a different, more specific issue if there's another related part of this I've forgotten about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.4.0
Projects
None yet
Development

No branches or pull requests

3 participants