Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow independent series fitting on x axes #1157

Open
Tracked by #2320
nickofthyme opened this issue May 12, 2021 · 0 comments
Open
Tracked by #2320

Allow independent series fitting on x axes #1157

nickofthyme opened this issue May 12, 2021 · 0 comments
Labels
:data Data/series/scales related issue enhancement New feature or request :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented May 12, 2021

Is your feature request related to a problem? Please describe.
Yes, the issue is that when using any fit type on a series when there are multiple series specs declared, this causes the fit logic to fill the gaps. This treats all series as if they represent the same data, more specifically it assumes all x values are shared across all series effectively coupling all series to each other.

See https://codesandbox.io/s/nostalgic-fast-q5q88?file=/src/App.tsx for an example like this...

image


Another case that could apply to this fitting logic is if the x values are nearly matching but shifted by some infinitesimal amount. If both series are using some fit type, they will both render as if they have discontinuous data.

See https://codesandbox.io/s/zen-shamir-pe4ho?file=/src/App.tsx for an example of this...

image

In this image the threshold is 1 minute ahead of the actual data timestamp.

Describe the solution you'd like
Allow different series specs to be independent in terms of fitting logic. This would not affect the domain extents just how the fitting is applied.

Describe alternatives you've considered

  • Don't use series fitting at all
  • Fill values to match each series domain where needed.
@nickofthyme nickofthyme added enhancement New feature or request :data Data/series/scales related issue labels May 12, 2021
@markov00 markov00 added the :xy Bar/Line/Area chart related label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:data Data/series/scales related issue enhancement New feature or request :xy Bar/Line/Area chart related
Projects
None yet
Development

No branches or pull requests

2 participants