Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top/bottom grid lines missing #1311

Open
2 tasks
Tracked by #2320
monfera opened this issue Aug 19, 2021 · 3 comments
Open
2 tasks
Tracked by #2320

Top/bottom grid lines missing #1311

monfera opened this issue Aug 19, 2021 · 3 comments
Labels
bug Something isn't working discuss To be discussed Impact:Low :xy Bar/Line/Area chart related

Comments

@monfera
Copy link
Contributor

monfera commented Aug 19, 2021

Describe the bug

The horizontal grid line for the bottom / zero Y intercept is missing, and sometimes, the topmost grid line is missing. I assume it's not intended, because there seems to be no need for omitting them; it looks a bit lopsided; the top one is sometimes present (see small multiples shot); and the leftmost/rightmost grid lines are not omitted either

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:9001/?path=/story/small-multiples-alpha--grid-lines
  2. Click on knobs to enable left/right axis grids
  3. See that there's no grid line on the bottom

Expected behaviour
Gridline for the Y=0 too

Screenshots
image

image

Version (please complete the following information):

  • OS: OS X
  • Browser: fresh chrome
  • Elastic Charts: master as of morning of isssue creation date

Checklist

Delete any items that are not applicable to this issue.

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@monfera monfera added bug Something isn't working :xy Bar/Line/Area chart related labels Aug 19, 2021
@nickofthyme
Copy link
Collaborator

AFAIR this is intentional #1204

@markov00 markov00 added the discuss To be discussed label Aug 25, 2021
@markov00
Copy link
Member

markov00 commented Aug 26, 2021

@monfera at the bottom, Y=0, there is already the Axis line so why do we need to display a grid line there?

@monfera
Copy link
Contributor Author

monfera commented Aug 30, 2021

Thanks, I'll do some thinking and possibly close it. Not sure if we should automatically elide the bottom grid line, and sometimes also the top gridline, as the original issue by @markov00 mentions the possibility for relying on the axis to simply overplot the bottom grid line, which sounds attractive, since the axis line is of higher priority than a grid line. A current workaround seems to be, style the axis line so it looks indistinguishable from a grid line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discuss To be discussed Impact:Low :xy Bar/Line/Area chart related
Projects
None yet
Development

No branches or pull requests

4 participants