Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gridline rendering on multi-layer time axis #1923

Open
Tracked by #2320
markov00 opened this issue Jan 3, 2023 · 1 comment
Open
Tracked by #2320

Improve gridline rendering on multi-layer time axis #1923

markov00 opened this issue Jan 3, 2023 · 1 comment
Labels
:axis Axis related issue enhancement New feature or request :styling Styling related issue

Comments

@markov00
Copy link
Member

markov00 commented Jan 3, 2023

Is your feature request related to a problem? Please describe.
With the new multilayer time axis, not all gridlines are shown. Only the major gridline is represented, but not all the sub layers.

Describe the solution you'd like
I'd like to:

  • give the ability to render all the grid lines (major, minor, background) lines or just the selected ones
  • improve the color/thinkness/opacity to make it works well on most cases, even denser ones.

To get all the layers you can easily change the following line:

notTooDense(domainFromS, domainToS, binWidth, cartesianWidth, MAX_TIME_GRID_COUNT)(l),

with a true.

Additional context

The timeslip prototype was great and the gridlines was a very valuable piece of the implementation. I don't see anymore a reason to not showing all the nice little details of such prototype.

Screenshot 2023-01-03 at 17 48 45

@markov00 markov00 added enhancement New feature or request :axis Axis related issue :styling Styling related issue labels Jan 3, 2023
@nickofthyme
Copy link
Collaborator

If possible I'd like to see this in all xy chart axes, especially for log scales, not just for multi-layer time axis. Similar to how excel offers major and minor axis configurations.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue enhancement New feature or request :styling Styling related issue
Projects
None yet
Development

No branches or pull requests

2 participants