Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customSeriesColors as function #507

Closed
stacey-gammon opened this issue Jan 3, 2020 · 1 comment
Closed

customSeriesColors as function #507

stacey-gammon opened this issue Jan 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@stacey-gammon
Copy link

According to Storybook docs, looks like customSeriesColors can be a function.

Screen Shot 2020-01-03 at 11 06 53 AM

But when I tried this, it threw an error:

Screen Shot 2020-01-03 at 11 04 47 AM

utils.js:72 Uncaught TypeError: spec.customSeriesColors.forEach is not a function

Though, I think storybook is tested so I'm not sure how it's working in there, unless that is a new feature and Kibana is on an older version. I looked in the pull requests but didn't find anything recent that matched by customSeriesColors search.
@stacey-gammon stacey-gammon added the bug Something isn't working label Jan 3, 2020
@markov00
Copy link
Member

It's now fixed thanks to #557
It was an issue with the Storybook addon-info addon, that doesn't render correctly the story sources. In the mentioned PR we are rendering the source code of each example with a different addon that shows a cleaner and more faithful source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markov00 @stacey-gammon