Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set synthetic source mode on new data streams #1026

Closed
jsoriano opened this issue Nov 7, 2022 · 7 comments · Fixed by #1261
Closed

Set synthetic source mode on new data streams #1026

jsoriano opened this issue Nov 7, 2022 · 7 comments · Fixed by #1261
Assignees
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@jsoriano
Copy link
Member

jsoriano commented Nov 7, 2022

Make elastic-package create to set source_mode: synthetic on new data streams. So this mode is enabled by default once elastic/kibana#141211 is ready.

This flag was added to the spec in elastic/package-spec#419. Synthetic source mode can be manually enabled through the UI since elastic/kibana#140095.

@juliaElastic
Copy link

@jsoriano Does this issue need QA validation?

@jsoriano
Copy link
Member Author

jsoriano commented Jun 5, 2023

@jsoriano Does this issue need QA validation?

I think it will be enough with testing it during review. @mrodm wdyt?

@ebeahan
Copy link
Member

ebeahan commented Jun 5, 2023

Make elastic-package create to set source_mode: synthetic on new data streams.

Will synthetic mode be default for all new data streams or just metric data streams?

@mrodm
Copy link
Contributor

mrodm commented Jun 5, 2023

@jsoriano Does this issue need QA validation?

I think it will be enough with testing it during review. @mrodm wdyt?

I would say it is enough with the testing done during the review (PR) process. Ensuring that the configuration written in the data stream manifest corresponds with the settings introduced by the user while running elastic-package create data-stream command.

@mrodm
Copy link
Contributor

mrodm commented Jun 5, 2023

Make elastic-package create to set source_mode: synthetic on new data streams.

Will synthetic mode be default for all new data streams or just metric data streams?

@ebeahan I was thinking to just allow that mode in case users/developers choose to create a metrics data stream in the package.

This means that elastic-package would show a question to the user/developer to choose if they want to enable synthetics or not. If they chose to create a logs data stream, no question will be shown and there would not be any changes in the configuration.

Would that make sense @jsoriano @ebeahan ?

@jsoriano
Copy link
Member Author

jsoriano commented Jun 5, 2023

@ebeahan I was thinking to just allow that mode in case users/developers choose to create a metrics data stream in the package.

This means that elastic-package would show a question to the user/developer to choose if they want to enable synthetics or not. If they chose to create a logs data stream, no question will be shown and there would not be any changes in the configuration.

Would that make sense @jsoriano @ebeahan ?

Makes sense to me, yes.

@ebeahan
Copy link
Member

ebeahan commented Jun 5, 2023

++ yes, makes sense to me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants