Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand__to_dot variable cannot be used to control the behavior #1633

Closed
samv-yazzoom opened this issue Nov 9, 2022 · 1 comment · Fixed by #1634
Closed

Expand__to_dot variable cannot be used to control the behavior #1633

samv-yazzoom opened this issue Nov 9, 2022 · 1 comment · Fixed by #1634
Labels
Category: Bug Something isn't right

Comments

@samv-yazzoom
Copy link

Hello,

This pull request: #809 moved the default for _expand__to_dot to a variable.
At load time, the default for _expand__to_dot will already be set to True. Overwriting EXPAND__TO_DOT after the import has not impact.

The variable would be usable if the default is resolved in the function definition.
@SamVermeulen42 SamVermeulen42 mentioned this issue Nov 9, 2022
Merged
@miguelgrinberg miguelgrinberg added the Category: Bug Something isn't right label Mar 25, 2024
@miguelgrinberg miguelgrinberg mentioned this issue Mar 25, 2024
Closed
@miguelgrinberg
Copy link
Collaborator

Duplicate of #1586

@miguelgrinberg miguelgrinberg marked this as a duplicate of #1586 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Bug Something isn't right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve _expand__to_dot default at runtime SamVermeulen42/elasticsearch-dsl-py
2 participants
@miguelgrinberg @samv-yazzoom