Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for auto slicing #147

Closed
norbson opened this issue Jan 31, 2022 · 1 comment · Fixed by #292
Closed

Missing support for auto slicing #147

norbson opened this issue Jan 31, 2022 · 1 comment · Fixed by #292
Labels
Area: Specification Related to the API spec used to generate client code

Comments

@norbson
Copy link

norbson commented Jan 31, 2022

In HLRC we can set slices to auto passing 0 as argument:

Params withSlices(int slices) {
  if (slices == 0) {
    // translate to "auto" value in rest request so the receiving end doesn't throw error
      return putParam("slices", AbstractBulkByScrollRequest.AUTO_SLICES_VALUE);
  }
  return putParam("slices", String.valueOf(slices));
        }

There is no such option in new java client:

if (request.slices != null) {
  params.put("slices", String.valueOf(request.slices));
}
@swallez swallez added the Category: Enhancement New feature or request label Mar 2, 2022
@swallez swallez added Area: Specification Related to the API spec used to generate client code and removed Category: Enhancement New feature or request labels May 20, 2022
@swallez
Copy link
Member

swallez commented May 24, 2022

This has been fixed in PR #292, backported to version 8.2 in PR #293 and to version 7.17 in PR #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Specification Related to the API spec used to generate client code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants