empty filter aggregation is now expected to fail

Author: Mpdreamz

src/Tests/Aggregations/Bucket/Filter/FilterAggregationUsageTests.cs

@@ -92,9 +92,10 @@ protected override void ExpectResponse(ISearchResponse<Project> response)
 	[SkipVersion("6.0.0-alpha1", "https://github.com/elastic/elasticsearch/issues/17518 && 6.0 https://github.com/elastic/elasticsearch/pull/17542#issuecomment-300796197")]
 	public class EmptyFilterAggregationUsageTests : AggregationUsageTestBase
 	{
-		public EmptyFilterAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage)
-		{
-		}
+		public EmptyFilterAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
+
+		protected override bool ExpectIsValid => false;
+		protected override int ExpectStatusCode => 400;
 
 		protected override object ExpectJson => new
 		{
@@ -132,8 +133,7 @@ public EmptyFilterAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage)
 
 		protected override void ExpectResponse(ISearchResponse<Project> response)
 		{
-			response.ShouldBeValid();
-			response.Aggs.Filter("empty_filter").DocCount.Should().BeGreaterThan(0);
+			response.ShouldNotBeValid();
 		}
 	}
 

src/Tests/Framework/EndpointTests/ApiIntegrationTestBase.cs

@@ -27,7 +27,7 @@ protected ApiIntegrationTestBase(ClusterBase cluster, EndpointUsage usage) : bas
 		protected override IElasticClient Client => this.Cluster.Client;
 		protected override TInitializer Initializer => Activator.CreateInstance<TInitializer>();
 
-		[I] public async Task HandlesStatusCode() =>
+		[I] public async Task ReturnsExpectedStatusCode() =>
 			await this.AssertOnAllResponses(r => r.ApiCall.HttpStatusCode.Should().Be(this.ExpectStatusCode));
 
 		[I] public async Task ReturnsExpectedIsValid() =>