Better randomized initial nodes test

This commit adds a better randomized initial nodes test by introducing a Thread.Sleep of 1 millisecond between successive instantiations of StaticConnectionPool. A new instance of Random is created for each instance of StaticConnectionPool, and the Random is initialized with Environment.TickCount, the number of milliseconds since the system started. To therefore ensure that seeds for successive instances of Random are different, a wait is introduced.

Author: russcam

src/Tests/Tests/ClientConcepts/ConnectionPooling/BuildingBlocks/ConnectionPooling.doc.cs

@@ -1,6 +1,8 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Text;
+using System.Threading;
 using Elastic.Xunit.XunitPlumbing;
 using Elasticsearch.Net;
 using FluentAssertions;
@@ -217,22 +219,25 @@ [U] public void Static()
 		// hide
 		[U] public void RandomizedInitialNodes()
 		{
-			StaticConnectionPool CreatStaticConnectionPool()
+			IEnumerable<StaticConnectionPool> CreatStaticConnectionPools()
 			{
+				Thread.Sleep(1);
+
 				var uris = new[]
 				{
 					new Uri("https://10.0.0.1:9200/"),
 					new Uri("https://10.0.0.2:9200/"),
 					new Uri("https://10.0.0.3:9200/")
 				};
 
-				var staticConnectionPool = new StaticConnectionPool(uris);
-				return staticConnectionPool;
+				yield return new StaticConnectionPool(uris);
 			}
 
 			// assertion works on the probability of seeing a Uri other than https://10.0.0.1:9200/
 			// as the first value over 50 runs, when randomized.
-			Enumerable.Repeat(CreatStaticConnectionPool().CreateView().First().Uri.ToString(), 50)
+			CreatStaticConnectionPools()
+				.Take(50)
+				.Select(p => p.CreateView().First().Uri.ToString())
 				.All(uri => uri == "https://10.0.0.1:9200/")
 				.Should()
 				.BeFalse();