Fix fluent serialization of if_primary_term (#4078) (#4087)

Fixes fluent serialization of if_primary_term for BulkIndexDescriptor and BulkUpdateDescriptor

(cherry picked from commit 0c5cbbd)

Author: andrx

src/Nest/Document/Multiple/Bulk/BulkOperation/BulkIndex.cs

@@ -79,6 +79,6 @@ public class BulkIndexDescriptor<T> : BulkOperationDescriptorBase<BulkIndexDescr
 
 		public BulkIndexDescriptor<T> IfSequenceNumber(long? seqNo) => Assign(seqNo, (a, v) => a.IfSequenceNumber = v);
 
-		public BulkIndexDescriptor<T> IfPrimaryTerm(long? primaryTerm) => Assign(primaryTerm, (a, v) => a.IfSequenceNumber = v);
+		public BulkIndexDescriptor<T> IfPrimaryTerm(long? primaryTerm) => Assign(primaryTerm, (a, v) => a.IfPrimaryTerm = v);
 	}
 }

src/Nest/Document/Multiple/Bulk/BulkOperation/BulkUpdate.cs

@@ -233,6 +233,6 @@ public BulkUpdateDescriptor<TDocument, TPartialDocument> IfSequenceNumber(long?
 		/// Operations can be made conditional and only be performed if the last modification to the document was assigned the primary term.
 		/// </summary>
 		public BulkUpdateDescriptor<TDocument, TPartialDocument> IfPrimaryTerm(long? primaryTerm) =>
-			Assign(primaryTerm, (a, v) => a.IfSequenceNumber = v);
+			Assign(primaryTerm, (a, v) => a.IfPrimaryTerm = v);
 	}
 }

src/Tests/Tests.Reproduce/GithubIssue4078.cs

@@ -0,0 +1,37 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Elastic.Xunit.XunitPlumbing;
+using FluentAssertions;
+using Nest;
+using Tests.Core.Client;
+using Tests.Core.Extensions;
+using Tests.Core.Serialization;
+using Tests.Domain;
+
+namespace Tests.Reproduce
+{
+	public class GithubIssue4078
+	{
+		[U]
+		public void BulkIndexOperationIssue() {
+
+			var indexResponse = TestClient.InMemoryWithJsonNetSerializer.Bulk(d =>
+				d.Index<Project>(i => i.IfSequenceNumber(12345).IfPrimaryTerm(67890).Document(Project.Instance))
+			);
+			Encoding.UTF8.GetString(indexResponse.ApiCall.RequestBodyInBytes).Should().Contain("\"if_seq_no\"").And.Contain("12345")
+				.And.Contain("\"if_primary_term\"").And.Contain("67890");
+		}
+
+		[U]
+		public void BulkUpdateOperationIssue()
+		{
+
+			var indexResponse = TestClient.InMemoryWithJsonNetSerializer.Bulk(d =>
+				d.Update<Project, object>(i => i.IfSequenceNumber(12345).IfPrimaryTerm(67890).Doc(Project.Instance))
+			);
+			Encoding.UTF8.GetString(indexResponse.ApiCall.RequestBodyInBytes).Should().Contain("\"if_seq_no\"").And.Contain("12345")
+				.And.Contain("\"if_primary_term\"").And.Contain("67890");
+		}
+	}
+}

src/Tests/Tests/Document/Multiple/Bulk/BulkInvalidVersionApiTests.cs

@@ -21,8 +21,7 @@ public BulkInvalidVersionApiTests(WritableCluster cluster, EndpointUsage usage)
 		{
 			new Dictionary<string, object> { { "index", new { _type = "doc", _id = Project.Instance.Name, routing = Project.Instance.Name } } },
 			Project.InstanceAnonymous,
-			new Dictionary<string, object>
-				{ { "index", new { _type = "doc", _id = Project.Instance.Name, routing = Project.Instance.Name, version = 0 } } },
+			new Dictionary<string, object> { { "index", new { _type = "doc", _id = Project.Instance.Name, routing = Project.Instance.Name, if_seq_no = -1, if_primary_term = 0 } } },
 			Project.InstanceAnonymous,
 		};
 
@@ -31,7 +30,7 @@ public BulkInvalidVersionApiTests(WritableCluster cluster, EndpointUsage usage)
 		protected override Func<BulkDescriptor, IBulkRequest> Fluent => d => d
 			.Index(CallIsolatedValue)
 			.Index<Project>(i => i.Document(Project.Instance))
-			.Index<Project>(i => i.Version(0).Document(Project.Instance));
+			.Index<Project>(i => i.IfSequenceNumber(-1).IfPrimaryTerm(0).Document(Project.Instance));
 
 		protected override HttpMethod HttpMethod => HttpMethod.POST;
 
@@ -41,7 +40,7 @@ public BulkInvalidVersionApiTests(WritableCluster cluster, EndpointUsage usage)
 			Operations = new List<IBulkOperation>
 			{
 				new BulkIndexOperation<Project>(Project.Instance),
-				new BulkIndexOperation<Project>(Project.Instance) { Version = 0 }
+				new BulkIndexOperation<Project>(Project.Instance) { IfSequenceNumber = -1, IfPrimaryTerm = 0 }
 			}
 		};
 
@@ -60,8 +59,8 @@ protected override void ExpectResponse(IBulkResponse response)
 			response.ShouldNotBeValid();
 			response.ServerError.Should().NotBeNull();
 			response.ServerError.Status.Should().Be(400);
-			response.ServerError.Error.Type.Should().Be("action_request_validation_exception");
-			response.ServerError.Error.Reason.Should().EndWith("illegal version value [0] for version type [INTERNAL];");
+			response.ServerError.Error.Type.Should().Be("illegal_argument_exception");
+			response.ServerError.Error.Reason.Should().Contain("sequence numbers must be non negative.");
 		}
 	}
 }