Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After/AfterKey dictionary types in Composite Aggregation/Aggregate #8173

Open
Tracked by #8356
gpetrou opened this issue Apr 26, 2024 · 1 comment
Open
Tracked by #8356

After/AfterKey dictionary types in Composite Aggregation/Aggregate #8173

gpetrou opened this issue Apr 26, 2024 · 1 comment
Labels
8.x Relates to 8.x client version Category: Enhancement Usability

Comments

@gpetrou
Copy link
Contributor

gpetrou commented Apr 26, 2024

Elastic.Clients.Elasticsearch version: 8.13.10

Elasticsearch version: 8.11

.NET runtime version: 8.0

Operating system version:

Description of the problem including expected versus actual behavior:
CompositeAggregate has an IReadOnlyDictionary<string, FieldValue>? AfterKey property.
CompositeAggregation has an IDictionary<Field, FieldValue>? After property.

Should these dictionaries have the same <string, FieldValue> types instead?

Steps to reproduce:
1.
2.
3.

Expected behavior
A clear and concise description of what you expected to happen.

Provide ConnectionSettings (if relevant):

Provide DebugInformation (if relevant):

@flobernd
Copy link
Member

Hi @gpetrou,

the generator flattens alias types like Field in responses as that makes usage easier in most cases. This place is special as that prevents us from passing the AfterKey dictionary directly to the After value for pagination.

I'll see what I can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to 8.x client version Category: Enhancement Usability
Projects
None yet
Development

No branches or pull requests

2 participants