Consolidate usage of FluentDescriptorDictionary

[niemyjski]

Elastic.Clients.Elasticsearch version: 8.15.6

Elasticsearch version: 8.15.1

.NET runtime version: 8.x

Operating system version: Any

Description of the problem including expected versus actual behavior:

In the past we built up queries and then assigned them to the descriptor. This is useful in our scenario but also in several apps when you want to conditionally build up queries based on method parameters over various control statements.

var result = await processor.BuildAggregationsAsync($"date:(field5~{interval})");
await Client.SearchAsync<MyType>(d => d.Index(index).Aggregations(result));

//  ElasticQueryParserTests.cs(712, 94): [CS0201] Only assignment, call, increment, decrement, await, and new object expressions can be used as a statement

var result = await processor.BuildQueryAsync("field1:value1", new ElasticQueryVisitorContext().UseSearchMode());
await Client.SearchAsync<MyType>(d => d.Index(index).Query(_ => result));
//   ElasticQueryParserTests.cs(717, 29): [CS0201] Only assignment, call, increment, decrement, await, and new object expressions can be used as a statement

Expected behavior

I should be able to apply built up query and aggregation descriptors to the fluent api

Reference: FoundatioFx/Foundatio.Parsers#84

[flobernd]

Hi @niemyjski,

this works fine for Query, if you omit the _ =>:

var query = new QueryDescriptor<Person>()
    .Term(t => t
        .Field("user.id")
        .Value("kimchy")
    );

var response = await client.SearchAsync<Person>(s => s
    .Query(query)
);

we always generate multiple overloads to support these kind of assignments:

public SearchRequestDescriptor<TDocument> Query(QueryDsl.Query? query)
public SearchRequestDescriptor<TDocument> Query(QueryDescriptor<TDocument> descriptor)
public SearchRequestDescriptor<TDocument> Query(Action<QueryDsl.QueryDescriptor<TDocument>> configure)

For aggregations it's slightly different, but this should work:

var aggs = new FluentDescriptorDictionary<string, AggregationDescriptor<Person>>();
aggs = aggs.Add("name1", agg => agg.Avg(avg => avg.Field("test")));
aggs = aggs.Add("name2", agg => agg.Min(min => min.Field("test")));

var response = await client.SearchAsync<Person>(s => s
    .Aggregations(_ => aggs)
);

As discussed in the other issue, it would be good to have an overload that directly accepts a regular collection of <string, Aggregation<T>> and <string, AggregationDescriptor<T>>.

Please let me know, if we can close this issue.

[niemyjski]

Feels like if you can do .Query(query) than this should work too .Aggregations(aggregations) (I need to confirm looks like I have a typing issue on my side, will confirm and close if we are good.

[github-actions]

This issue is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 2 days.