Fixed #846 choosing GET and POST in endpoints based on body

Author: ezimuel

src/Elasticsearch/Endpoints/Cluster/AllocationExplain.php

@@ -57,6 +57,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Count.php

@@ -82,6 +82,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/CountPercolate.php

@@ -85,6 +85,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Explain.php

@@ -95,6 +95,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/FieldCaps.php

@@ -64,6 +64,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/FieldStats.php

@@ -68,6 +68,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Indices/Analyze.php

@@ -74,6 +74,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Indices/ValidateQuery.php

@@ -72,6 +72,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Ingest/Simulate.php

@@ -60,6 +60,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/MTermVectors.php

@@ -65,6 +65,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'POST';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Mget.php

@@ -88,6 +88,6 @@ public function getBody()
      */
     public function getMethod()
     {
-        return 'POST';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Msearch.php

@@ -99,6 +99,6 @@ public function getBody()
      */
     public function getMethod()
     {
-        return 'GET';
+        return 'POST';
     }
 }

src/Elasticsearch/Endpoints/MsearchTemplate.php

@@ -100,6 +100,6 @@ public function getBody()
      */
     public function getMethod()
     {
-        return 'GET';
+        return 'POST';
     }
 }

src/Elasticsearch/Endpoints/Percolate.php

@@ -93,6 +93,6 @@ public function getBody()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/RenderSearchTemplate.php

@@ -72,6 +72,6 @@ public function getBody()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Scroll.php

@@ -97,6 +97,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/Search.php

@@ -107,6 +107,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/SearchTemplate.php

@@ -74,6 +74,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'GET';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

src/Elasticsearch/Endpoints/TermVectors.php

@@ -90,6 +90,6 @@ public function getParamWhitelist()
      */
     public function getMethod()
     {
-        return 'POST';
+        return isset($this->body) ? 'POST' : 'GET';
     }
 }

tests/Elasticsearch/Tests/Connections/ConnectionTest.php

@@ -5,6 +5,7 @@
 use Elasticsearch\ClientBuilder;
 use Elasticsearch\Connections\Connection;
 use Elasticsearch\Serializers\SerializerInterface;
+use Elasticsearch\Serializers\SmartSerializer;
 use Psr\Log\LoggerInterface;
 
 class ConnectionTest extends \PHPUnit\Framework\TestCase
@@ -38,7 +39,7 @@ function(){},
 
         $this->assertInstanceOf(Connection::class, $connection);
     }
-    
+
     public function testGetHeadersContainUserAgent()
     {
         $params = [];

tests/Elasticsearch/Tests/Endpoints/StatusEndpointTest.php

@@ -1,7 +1,4 @@
 <?php
-
-declare(strict_types = 1);
-
 namespace Elasticsearch\Tests\Endpoints;
 
 use Elasticsearch\Endpoints\Snapshot\Status;