Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same type for SearchRequest's body and MultisearchBody #1726

Open
swallez opened this issue May 24, 2022 · 1 comment
Open

Use the same type for SearchRequest's body and MultisearchBody #1726

swallez opened this issue May 24, 2022 · 1 comment
Labels
discuss lang:java Affects/found in the Java client specification

Comments

@swallez
Copy link
Member

swallez commented May 24, 2022

SearchRequest body and MultisearchBody have exactly the same properties. They should actually be the same type: beyond removing the need to keep them in sync, this also allows using that same type to build both search requests and multisearch request items.

This will be a breaking change since we need to rename MultisearchBody to something like SearchRequestBody and update SearchRequest to use it as a value body.

Reported in elastic/elasticsearch-java#151
@swallez swallez added specification discuss lang:java Affects/found in the Java client labels May 24, 2022
@swallez swallez mentioned this issue May 24, 2022
Open
@Erkanerkisi
Copy link

Hi, Is there any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss lang:java Affects/found in the Java client specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swallez @Erkanerkisi