[TEST] Fix RolloverActionTests.mutateInstance

In some cases it wasn't mutating and caused test failures

Author: dakrone

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/RolloverActionTests.java

@@ -48,20 +48,21 @@ protected RolloverAction mutateInstance(RolloverAction instance) throws IOExcept
         TimeValue maxAge = instance.getMaxAge();
         Long maxDocs = instance.getMaxDocs();
         switch (between(0, 2)) {
-        case 0:
-            maxSize = randomValueOtherThan(maxSize, () -> {
-                ByteSizeUnit maxSizeUnit = randomFrom(ByteSizeUnit.values());
-                return new ByteSizeValue(randomNonNegativeLong() / maxSizeUnit.toBytes(1), maxSizeUnit);
-            });
-            break;
-        case 1:
-            maxAge = TimeValue.parseTimeValue(randomPositiveTimeValue(), "rollover_action_test");
-            break;
-        case 2:
-            maxDocs = randomNonNegativeLong();
-            break;
-        default:
-            throw new AssertionError("Illegal randomisation branch");
+            case 0:
+                maxSize = randomValueOtherThan(maxSize, () -> {
+                    ByteSizeUnit maxSizeUnit = randomFrom(ByteSizeUnit.values());
+                    return new ByteSizeValue(randomNonNegativeLong() / maxSizeUnit.toBytes(1), maxSizeUnit);
+                });
+                break;
+            case 1:
+                maxAge = randomValueOtherThan(maxAge,
+                    () -> TimeValue.parseTimeValue(randomPositiveTimeValue(), "rollover_action_test"));
+                break;
+            case 2:
+                maxDocs = maxDocs == null ? randomNonNegativeLong() : maxDocs + 1;
+                break;
+            default:
+                throw new AssertionError("Illegal randomisation branch");
         }
         return new RolloverAction(maxSize, maxAge, maxDocs);
     }